MobileNativeFoundation / MobileNativeFoundation/rules_xcodeproj

Feature Request: Enhanced support for `swift_{grpc,proto}_library`

Open
#1,744 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Swift
Stars
626
Forks
124
No merged PRs in 30d

Description

  • A target needs to be created for each proto_library that is a transitive dependency of the swift_proto_library. A target shouldn't be made for swift_proto_library itself.
  • An external target for @com_github_apple_swift_protobuf//:SwiftProtobuf need to be the dependency of these.
  • The X.pb.swift generated files need to be sources of these proto_library targets.
  • Show generated files in Xcode: #1837

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the swift_{grpc,proto}_library entry points but no files or tests. Start by tracing their transitive proto_library dependencies and the generated X.pb.swift files; done means implementing the three dependency/source requirements and separately addressing generated-file visibility in Xcode as described by #1837.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.