MobileNativeFoundation / MobileNativeFoundation/rules_xcodeproj

Address Bazel Starlark lint warnings about module visibility

Open
#134 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup
Dominant language
Swift
Stars
626
Forks
124
PR merge metrics
No merged PRs in 30d

Description

There are a number of # buildifier: disable=bzl-visibility directives sprinkled throughout the codebase. The primary issue is that by convention code under private or internal directories should not be accessible in other parts of the codebase. We should discuss how we want visibility to work in the repository and then update the code so that these directives can be removed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository-wide # buildifier: disable=bzl-visibility directives and the conventions for private and internal directories. The issue requires first deciding how visibility should work, then updating the affected code so those directives can be removed; no specific files or tests are named.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.