MobileNativeFoundation / MobileNativeFoundation/rules_xcodeproj
Feature Request: Optimize `swift_debug_settings.py`
Open
@brentleyjones is already working on this.
Since Jan 5, 2023.
feature request
- Dominant language
- Swift
- Stars
- 626
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
Similar to #1020.
- In BwX mode, only set settings for top-level targets that have unfocused dependencies. Currently it will generate for all top-level targets if there are any unfocused targets anywhere in the build graph.
- Generate this file over in Starlark. Has the same requirement as moving
link.paramsover there:FilePathResolverand related logic (mainlyxcodeGeneratedFiles) needs to migrate over to Starlark. (https://github.com/buildbuddy-io/rules_xcodeproj/pull/1670) - Consider splitting the file per top-level target. The main file can load the file for the required top-level target. For some projects with lots of dependencies (and even more so if those dependencies are Objective-C) the settings for each top-level target is quite large. This should speed up module loading.
- Generate the file(s) on-demand, as part of the
xl/bloutput groups
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.