MixinNetwork / MixinNetwork/flutter-plugins

[desktop_webview_window v0.2.3] Webview crashes if window is manipulated before fully initializing

Open
#366 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
512
Forks
292
Avg merge
15h 8m
Merged PRs (30d)
7

Description

When the webview window is created, if you press minimize too early the entire application crashes.

Reproduce Steps

Steps to reproduce the behavior:

  1. Open Flutter app
  2. Call WebviewWindow.create
  3. As soon as window opens, press minimize
  4. App crashes

Expected behavior

The window should minimize without crashing

Version (please complete the following information):

  • Flutter 3.22.3, Dart 3.4.4
  • Windows 11 Pro | 23H2 | 22631.3880
  • desktop_webview_window v0.2.3

EXCEPTION_ACCESS_VIOLATION_READ / 0x0

  • webview_window::WebView::UpdateBounds (web_view.cc:202)

note that adding null check resolves issue and everything behaves as expected, haven't delved deep enough to see if has any repercussions

image image

Here's the parameters the webview is initialized with
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in web_view.cc at WebView::UpdateBounds, especially line 202, and reproduce the crash by minimizing immediately after WebviewWindow.create. Check the initialization timing and the reported null-check behavior, then verify that early minimization no longer causes an access violation.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart, flutter
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.