MithrilJS / MithrilJS/mithril.js

npm mithril + ospec binary conflict

Open
#2,794 3 comments 1 reaction 1 assignee View on GitHub

@dead-claudia is already working on this.

Since Sep 2, 2024.

Area: Core Area: Workflow Type: Bug
Dominant language
JavaScript
Stars
14.5k
Forks
922
PR merge metrics
No merged PRs in 30d

Description

Following on from the discussion starting here in the chat.

Mithril's internal ospec is deprecated and console.warns to this effect on execution, recommending the canonical npm install of ospec. However, installing this as directed doesn't override Mithril's binary path binding for its internal ospec. From my tests, whichever is installed first, installing both mithril & ospec always results in the Mithril's ospec binding taking precedence; @orbitbot says he is able to get ospec to take precedence based on installation sequence, but I couldn't replicate.

The issue of conflicting binary path registrations in npm package dependencies has been raised at least a couple of times (npm#7130 & npm#9040) but the trail has run cold seemingly without resolution.

I've raised a discussion on the npm Github org feedback site – but maybe I ought to revive one of the issues above or file a new one?

In the meantime we might be able to advise a hack to account for the current deprecation warning's failure. 🤔

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.