MithrilJS / MithrilJS/mithril-query
Need to pass children to mq
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 106
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
It looks like mq only accepts a component or a component + attrs: https://github.com/MithrilJS/mithril-query/blob/master/index.js#L245
In theory, it should be able to support component, component + attrs, or component + attrs + children (MyComponent, attrs, children)?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at index.js around line 245, where mq currently accepts a component or component plus attrs. Trace how arguments are passed into the component and identify the existing test entry point for mq, if present. Done means mq also accepts component, attrs, and children without breaking the existing forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100