Mission-DMX / Mission-DMX/Project-Editor
Find out how to best deal with the update of bank set ids
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10
- Forks
- 1
- Avg merge
- 27m
- Merged PRs (30d)
- 1
Description
Currently a bank set changes its ID prior to updating itself if it was already pushed to fish in order to keep the current bank set running until the whole operation is finished. This creates the issue, that the filters in the model are not updated automatically if there is no corresponding graph node object.
There are multiple ways to best deal with this situation:
- Make sure that a change of IDs isn't required. For example by making the fader filters check for avaiability first
- Register the fader filters with the ID update listeners
- Make fader filters always use the scenes bank set and update them accordingly
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how bank set IDs change before an update, then inspect how fader filters and graph node objects receive those changes. Compare the three approaches listed in the issue and determine which preserves the current bank set until the operation finishes while keeping filters consistent. Done means the chosen behavior is implemented and the missing graph-node case no longer leaves filters outdated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100