Mission-DMX / Mission-DMX/Project-Editor
Filter default values are not reliable
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10
- Forks
- 1
- Avg merge
- 27m
- Merged PRs (30d)
- 1
Description
Using the default parameters of filters does not always work. I suspect the reason to be the issue that their values are assigned in filter nodes which are a part of the view and only assigned once the corresponding filter page is loaded. Instead we should separate the filter models from the view (which we should do anyway) and see if this fixes the issue.
I think it is best, if regular filters are implemented as sub classes of filter as well. The factory for virtual filters could be expanded for regular filters as well, which should clean up the filter creation code.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the filter nodes in the view, the filter pages that load them, and the existing virtual-filter factory. Trace how regular and virtual filter models are created and when default values are assigned. Done means filter defaults work reliably before the corresponding page is loaded, with regular filters handled through the proposed filter hierarchy and factory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100