Miserlou / Miserlou/RJModules

error on make dist and submodule update

Open
#64 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
101
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Fedora 23 Linux
VCV Rack v1.dev
GCC 5.3.1

mkdir -p dist/"RJModules"
cp plugin.so dist/"RJModules"/
strip -s dist/"RJModules"/plugin.so
cp -r --parents LICENSE.txt res soundfonts samples rawwaves plugin.json dist/"RJModules"/
cp: cannot stat ‘rawwaves’: No such file or directory
../../plugin.mk:55: recipe for target 'dist' failed
make: *** [dist] Error 1

I figured out the fix for this one. I have the rawwaves folder for Csound's STK opcodes, but it took a while to learn where the module expects to find it. The module will crash Rack if I try to load it without the correct folder path. I put the folder in my home directory, the module now loads. I'll test it later this evening. Cool module, I've been waiting for something like it. Someone started an STK-based plugin a long time ago, but I don't know if it was ever completed for any version of VCV Rack.

Also:

$ git submodule update --init --recursive
error: invalid key (newline): submodule.dep/libsndfile
libsndfile.url
error: invalid key (newline): submodule.dep/libsndfile
libsndfile.url
No url found for submodule path 'dep/libsndfile' in .gitmodules

Not sure what to do about this one. Suggestions ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with plugin.mk around line 55 and the repository's .gitmodules file. Reproduce make dist and git submodule update --init --recursive, then inspect how rawwaves and dep/libsndfile are expected to be provided. Done means the distribution build and recursive submodule update complete without these errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, git
Domain
build-system, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.