Miserlou / Miserlou/JonesComplexity

f'' strings commplexity

Open
#38 3 comments 1 reaction 1 assignee View on GitHub

@sobolevn is already working on this.

Since Jul 6, 2018.

Dominant language
Python
Stars
30
Forks
4
No merged PRs in 30d

Description

Simple f'for {url} error code {code} with message {msg} ' string (which is aprt of multi-line string) scores 20 complexity.
Full context:

spider.logger.error(
    f'for {url} error code {code} with message {msg} '
    f'and the following session info:\n'
    f'{pprint.pformat(response.meta[spider.META_SESSION_INFO])}'
)

And plugin warns only about second line.

Is it OK?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.