MirrorNetworking / MirrorNetworking/Mirror
NetworkIdentity.DeserializeServer sets all [SyncVar] dirty bits instead of the synced ones
Open
@miwarnec is already working on this.
Since Dec 5, 2022.
enhancement
- Dominant language
- C#
- Stars
- 6.3k
- Forks
- 870
- PR merge metrics
- No merged PRs in 30d
Description
that's because not all OnSerialize calls may have SyncVars.
however, OnDeserialize calls the syncvar setter for the ones which were modified.
-> simply set the dirty bit there.
... and then remove the SetDirty() call? but what about other types?
maybe only call SetDirty() if syncVarDirtyBits == 0 after deseriaalize
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.