Mirantis / Mirantis/cri-dockerd
cri-dockerd does not set Resources to ContainerStatus
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 356
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 3
Description
cri-dockerd does not set Resources to ContainerStatus code
For comparison containerd sets it code
This results to K8s failure to throttle pod so that it follows resized CPU limit on minikube when cri-dockerd is used.
InPlacePodVerticalScaling in K8s is soon going to reach Beta and luck of such support from cri-dockerd means that end users will face this limitation as described https://github.com/kubernetes/kubernetes/issues/118371 in minikube if cri-dockerd is used.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in core/container_status.go at the referenced line and inspect how ContainerStatus is assembled, then compare the reported behavior with the containerd implementation. Confirm that Resources is populated and that resized CPU limits no longer cause the Kubernetes throttling failure described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100