Mirantis / Mirantis/cri-dockerd
Switch container logging to a log driver
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 356
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 3
Description
Current Behavior
The current change made in #224 tails the log file created by docker. This works but there are some potential issues with it on windows.
Solution
A better setup would be to write a container log driver that cri-dockerd installs when it is installed. This log driver would write the log output to both the standard docker json file and the kube cri formatted file.
A fallback could also be setup, in case the driver isn't installed, which attaches to the container and streams the log output using https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerAttach or https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerLogs
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the logging change in #224 and the Docker ContainerAttach and ContainerLogs API references linked in the issue. Clarify how cri-dockerd would install and select the driver, then define validation for Docker's JSON log and kube-CRI formatted outputs, including the fallback behavior when the driver is unavailable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100