Mirantis / Mirantis/cri-dockerd
Support disabling automatic "rslave" fallback
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 356
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 3
Description
While containerd and CRI-O consistently maps PROPAGATION_PRIVATE (CRI) to rprivate (OCI),
cri-dockerd (dockerd) conditionally maps it to either rprivate or rslave:
cri-dockerd should have an option to disable falling back to rslave, without sacrificing backward compatibility.
-
Plan A: Introduce a custom Pod annotation like
cri-dockerd.mirantis.com/deterministic-propagation=true. -
Plan B: Add a new constant like
PROPAGATION_LITERALLY_PRIVATEto the CRI API.
In the YAML it would look likemountPropagation: LiterallyNone. -
Plan C: Just return an error when
recursivelyReadOnly == Required && propagation == None aka private && sourceContainsDaemonRoot.recursiveReadOnlyis proposed in https://github.com/kubernetes/enhancements/pull/3858
Plan B probably needs going through the full KEP process, which may take several years.
So, my preference is Plan A or C.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with libdocker/helpers.go at the linked propagation-mapping code and review how cri-dockerd handles PROPAGATION_PRIVATE. Compare the proposed annotation and error approaches, including the recursive-read-only case, before choosing an implementation path. Done means users can disable the rslave fallback while existing behavior remains compatible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100