MiniMax-AI / MiniMax-AI/minimax-code

create-agent skill documents per-agent model/thinking config that the runtime silently discards

Open
#124 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

desktop documentation needs-triage
Dominant language
TypeScript
Stars
1.3k
Forks
141
Avg merge
2h 45m
Merged PRs (30d)
46

Description

The bundled create-agent skill (assets/skills/create-agent/SKILL.md) tells agents to set per-agent model: <provider>/<model> and a thinking: block in agents/<name>/config.yaml ("Add when: The default model is wrong for this role"). In the current runtime this mechanism does not exist:

  • @mavis/local-runtime/dist/agent/sqlite-store.js normalizeConfig() keeps only defaultWorkspaceDir from the agent's config file — model and thinking keys are read and silently dropped (no warning logged).
  • Resolved model comes exclusively from the session's effectiveModel (UI model picker, set via api/routes/agents.ts) or the global root config.yaml defaultModel; children inherit the session model (local-task-runner.ts).
  • Additionally, thinking.effort on custom-provider model entries is not honored: model-resolver.js reads configuredEffort only on the builtin provider.* tree; the BYOK path (model-resolver-byok.js) passes none, so the emitted thinking level is the mode-derived default.

Counter-example that works: per-session model selection via the UI picker, and thinking_config.mode on model entries (verified: switchable toggle emits thinking:{type:enabled/disabled} for DeepSeek via openai-completions.js).

Ask: either implement per-agent model:/thinking: in agent config files (and wire configuredEffort for BYOK custom providers), or correct the create-agent skill docs to point at the session-picker mechanism. Silent dropping of documented config is the dangerous part.

Evidence: config.yaml agent entries containing only defaultWorkspaceDir (verified on 13 agents); runtime source quoted above; version MiniMax Code desktop v3.0.57.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with assets/skills/create-agent/SKILL.md and normalizeConfig() in @mavis/local-runtime/dist/agent/sqlite-store.js, then trace model selection through api/routes/agents.ts, local-task-runner.ts, model-resolver.js, and model-resolver-byok.js. Decide whether agent-file settings should work or the skill should direct users to session selection, and verify the documented path no longer silently misleads users or drops relevant configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.