MicrosoftEdge / MicrosoftEdge/WebView2Samples
Just say no to wil::com_ptr
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 521
- Avg merge
- 13m
- Merged PRs (30d)
- 1
Description
Is a legitimate call :)
I made that work (after setting to "no exceptions" in project properties) and by replacing two usages of wil::com_ptr with Microsoft::WRL::ComPtr.
There is now the warning about not having /EHsc, emanating from ppltasks.h , but that is a much larger subject.
I assume now I need to install WV2 RT to make it work.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the sample project properties and the two usages of wil::com_ptr mentioned in the issue, then inspect the ppltasks.h warning and the Microsoft::WRL::ComPtr replacement context. The issue does not specify a file, reproducible failure, or acceptance criteria, so the expected completed change is unclear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100