MicrosoftEdge / MicrosoftEdge/WebView2Samples
Detzection logic in Bundle.wxs seems wrong
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 521
- Avg merge
- 13m
- Merged PRs (30d)
- 1
Description
To detect whether Webview2 is installed, WebView2Samples/SampleApps/WV2DeploymentWiXBurnBundleSample/Bundle.wxs uses
<util:RegistrySearch Root="HKLM" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Value="EBWebView" Variable="WVRTInstalled" Win64="no" />
According to https://docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution and my own experience, the value should however be "pv", not "EBWebView". i.e.
<util:RegistrySearch Root="HKLM" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Value="pv" Variable="WVRTInstalled" Win64="no" />
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open WebView2Samples/SampleApps/WV2DeploymentWiXBurnBundleSample/Bundle.wxs and inspect the util:RegistrySearch entry for the WebView2 registry key. Compare its Value attribute with the linked WebView2 distribution guidance and the reported installed registry value; done means the bundle detects an installed WebView2 runtime correctly.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100