MicrosoftEdge / MicrosoftEdge/WebView2Samples
ShellExecuteEx does not wait for process exit
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 521
- Avg merge
- 13m
- Merged PRs (30d)
- 1
Description
https://github.com/MicrosoftEdge/WebView2Samples/blob/8ec7de9d3e80a942bc7025cffad98eee75e11e64/SampleApps/WebView2APISample/AppWindow.cpp#L74-L81
When ShellExecuteEx returned, the installer is still installing.
A solution is to set SEE_MASK_NOCLOSEPROCESS flag, and then WaitForSingleObject(shExInfo.hProcess).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in SampleApps/WebView2APISample/AppWindow.cpp at lines 74-81 and reproduce the installer behavior described in the issue. Check the ShellExecuteEx documentation linked there, then verify that the installer process has exited before the surrounding operation continues. Confirm the sample still builds and the installer no longer runs asynchronously.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100