MicrosoftEdge / MicrosoftEdge/Demos
Temperature convertor uses favicon.png instead of icon512.png
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 330
- Forks
- 233
- Avg merge
- 21h 12m
- Merged PRs (30d)
- 4
Description
bug in Demos repo /Demos/pwa-getting-started/
Fixed in PR 104; shown in PR 3476 (but icon512.png still needs transparent pixels):
- PR 3476 (Change "Get started PWAs" tut to code expl + steps to use sample) in the Docs repo
- PR 104 (Rename /pwa-getting-started/ dir to /temperature-converter/) in the Demos repo
The temperature convertor sample code uses /static/favicon.png
but should instead use /pwa-getting-started/icon512.png
@captainbrosset
live pwa:
https://microsoftedge.github.io/Demos/pwa-getting-started/
PR Comment
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The affected sample is under /Demos/pwa-getting-started/; begin by locating the code that references /static/favicon.png and compare it with the live PWA. Done means the sample uses /pwa-getting-started/icon512.png, while the linked PRs and the note about transparent pixels in icon512.png should be checked before taking ownership.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100