MichalLytek / MichalLytek/type-graphql

Introspection produces unexpected results after upgrading to 1.2.0-rc.1

Open
#1,149 1 comment 0 reactions 0 assignees View on GitHub
Need More Info :man_shrugging: Question :grey_question:
Dominant language
TypeScript
Stars
8.1k
Forks
672
PR merge metrics
No merged PRs in 30d

Description

**Describe the Bug**
After upgrading to 1.2.0-rc.1, when GraphQL Playground runs an introspection query, it will complain about input types that have no fields.

**To Reproduce**
Create an input type where all fields are deprecated.

**Expected Behavior**
The deprecated fields are returned, the introspection succeeds and GraphQL Playground is able to operate normally.

**Environment (please complete the following information):**

- OS: Windows WSL
- Node 16.x
- Package version 1.2.0-rc.1
- TypeScript version 4.5.4

**Additional Context**
From what I understand, this is likely caused by the graphql-js upgrade. I found https://github.com/graphql/graphql-js/issues/2834 which hints at this issue. I found no way how to affect this behavior from type-graphql itself.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the introspection query in GraphQL Playground with an input type whose fields are all deprecated, using package version 1.2.0-rc.1 and the reported TypeScript and Node versions. Read the linked graphql-js issue #2834 and compare the graphql-js upgrade behavior. Done means deprecated fields are returned, introspection succeeds, and GraphQL Playground operates normally.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, typescript
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.