MiSTer-devel / MiSTer-devel/Scripts_MiSTer
ini_settings.sh Font Change Bug
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 122
- Forks
- 49
- Avg merge
- 8h 56m
- Merged PRs (30d)
- 1
Description
When using the ini_settings.sh script to change the display font in MiSTer, if your font is set to one with a + in it (such as in Arcade_Cotton_(Sega_+_Success).pf), the string proceeding the plus sign is not parsed. Unfortunately this has the side effect of any subsequent changes failing to match entries in the font directory as they'll have the +_Success).pf string appended to them.
I believe this would require an edit to either/or the getVALUE or setVALUE functions to allow for a + literal in the grep sets.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading ini_settings.sh, especially the getVALUE and setVALUE functions and their grep expressions. Reproduce the issue with a font name containing a literal plus sign, then verify that subsequent font changes still match the font directory entries correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100