MiSTer-devel / MiSTer-devel/Scripts_MiSTer
Python 3 breaks mra_rom_check.sh
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 122
- Forks
- 49
- Avg merge
- 8h 56m
- Merged PRs (30d)
- 1
Description
You cannot mix tabs and spaces, according the PEP8 styleguide:
Spaces are the preferred indentation method.
Tabs should be used solely to remain consistent with code that is already indented with tabs.
Python 3 disallows mixing the use of tabs and spaces for indentation.
Python 2 code indented with a mixture of tabs and spaces should be converted to using spaces exclusively.
When invoking the Python 2 command line interpreter with the -t option, it issues warnings about code that illegally mixes tabs and spaces. When using -tt these warnings become errors. These options are highly recommended!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect mra_rom_check.sh, focusing on the Python code or invocation identified by the Python 3 failure and the reported mixed indentation. Run the script with Python 3 to reproduce the problem, then verify it completes without indentation errors and retains its existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, shell
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100