Meteor-Community-Packages / Meteor-Community-Packages/raix-push

push is missing when updated phonegap plugin push from 1.8.2 to 2.0.0

Open
#315 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
505
Forks
191
PR merge metrics
No merged PRs in 30d

Description

I have this code that is working properly at phonegap-plugin-push@1.8.2

                Push.push.setApplicationIconBadgeNumber(() => {
                    console.log('Push.setBadge: ', activityBadgeCount);
                }, (e) => {
                    console.log('Push.setApplicationIconBadgeNumber: Error', e.message);
                }, activityBadgeCount);

recently i updated to phonegap-plugin-push@2.0.0 and logged "Push" , it does not contain "Push.push" anymore, thus resulting to an error :

image

I have tried to check the repository the only difference I saw is that phonegap implemented 'use strict' does this affect Raix thus removing the push function?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Push.push.setApplicationIconBadgeNumber call and compare the plugin's exposed Push object between versions 1.8.2 and 2.0.0. Check whether the API change is related to the plugin update or to use strict; done means the badge-number call works on 2.0.0 or the incompatibility is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.