Meteor-Community-Packages / Meteor-Community-Packages/meteor-postcss
Remove app-module-path-node dependency
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 66
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
We tracked down [an issue with the Todos app](https://github.com/meteor/todos/issues/107#issuecomment-212905737) to the use of `app-module-path-node` in this package. Because `app-module-path-node` patches Node internals to modify module resolution, the Cordova code ends up with a faulty version of a package installed in the app's `node_modules` directory instead of the local one.
Modifying module resolution in this way could potentially break other parts of the build tool too, as it allows apps to override versions of packages we ship in the dev bundle.
Is there any way you can get rid of this dependency? I'm not sure what made you rely on this behavior, but we may be able to help you find a better way to accomplish this without globally modifying Node internals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating where app-module-path-node is declared and used in this package, then read the linked Todos issue and its referenced comment for the failure details. Done means the dependency and its module-resolution behavior are removed without causing Cordova code to select faulty packages from an app's node_modules directory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100