Meteor-Community-Packages / Meteor-Community-Packages/meteor-fast-render

IsAppUrl filter & curl

Open
#8 2 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
JavaScript
Stars
13
Forks
5
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Meteor-Community-Packages/meteor-fast-render/blob/0a3e50c69e276ab7e2c988c113a2e5fa3a1df002/lib/server/utils.js#L29

IsAppUrl makes SSR feature impossible with crawlers like curl which have accept header fixed to `*/*` (all)

Maybe it should be replaced by :
```es
return /html|\*\/\*/.test(req.headers.accept);
```

Contributor guide

Open the contributing guide

Research direction

Start at lib/server/utils.js line 29 and inspect how IsAppUrl evaluates the request Accept header. Reproduce the behavior with a crawler such as curl using its */* header, then verify that HTML and */* requests are treated as app URLs without breaking other cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.