Meteor-Community-Packages / Meteor-Community-Packages/meteor-autocomplete

Clicking around the input and changing cursor position does not change autocomplete filter

Open
#44 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
CoffeeScript
Stars
350
Forks
106
PR merge metrics
No merged PRs in 30d

Description

Changing the cursor via mouse does not update the autocomplete menu (due to this being handled in the `onKeyUp`) function of the `AutoComplete` class. The only other place this logic is also triggered is in `onFocus`.

We can simply add an `onClick` handler to tackle the basic case of this, but it requires more thought to decide what to do for drags and selected regions. Maybe the autocomplete should just go away during that time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AutoComplete class and compare the existing onKeyUp and onFocus handling described in the issue. Reproduce the behavior by moving the cursor with the mouse, then determine the intended behavior for clicks, drags, and selected regions. Done means cursor-position changes produce the expected autocomplete behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
coffeescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.