MetaMask / MetaMask/test-dapp

[Bug]: Deploying a failing contract turns into a success Contract Deployment event

Open
#172 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
642
Forks
369
PR merge metrics
No merged PRs in 30d

Description

**Problem**: when I click on Deploy a failing contract, I'm expecting to see an error on the transaction log, but I see that Contract is deployed successfully (apparently).

https://user-images.githubusercontent.com/54408225/172138654-c3590c7c-8816-497b-978e-00b6d6082eda.mp4

**Expectation**: we should see an error saying "Failed" on the contract log transaction, like in the case below

https://user-images.githubusercontent.com/54408225/172138693-fa86ab56-3dfe-4bd8-9834-9708fa9ab536.mp4

**Steps**:
1. Go to Test Dapp
2. Connect Metamask
3. Click Deploy Failing contract
4. Check Transaction activity tab

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the Test Dapp deployment flow and reproduce the listed steps with the Deploy Failing contract action. Check the Transaction activity tab and trace how the deployment result is displayed; done means a failed deployment shows an error marked "Failed" rather than "Contract is deployed successfully."

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.