MetaMask / MetaMask/test-dapp-multichain
Test Dapp Multichain: Testability improvement with `data-testid`
@ffmcgee725 is already working on this.
Since Jan 9, 2025.
- Dominant language
- TypeScript
- Stars
- 7
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Due to how we have our end to end selenium web driver API setup, if some HTML elements don't have a proper class, id or data-testid for manipulation through the API, the requirement for 'hacky' end to end test code increases.
We have noticed on a lot of these cases, when we want to fetch specific results of a call / interaction, we resort to fetching them through elements with the `result-summary-{number}` selector, which is not precise enough and requires extra code for parsing and filtering the actual result we want to test against
In order to avoid this, let's make sure we go through all HTML elements with selectos `result-summary` and add `data-testids` with proper naming according to the section it is in, so we can more easily test against these in the future.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.