MetaMask / MetaMask/snaps

Use fake timers for `SnapController` tests

Open
#619 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
853
Forks
662
Avg merge
2d 8h
Merged PRs (30d)
8

Description

Since removing Electron we now have the option to use fake timers for our tests, we should do that 👍

Contributor guide

Open the contributing guide

Research direction

Locate the SnapController test suite and review how its tests currently wait for timers. Check the repository's existing fake-timer test patterns before deciding which cases can use them. Done means the relevant tests use fake timers where appropriate and still pass reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.