MetaMask / MetaMask/snaps

Improve superstruct error messaging in `snaps-rpc-methods`

Open
#2,425 2 comments 0 reactions 0 assignees View on GitHub
snaps-deferred snaps-maintenance
Dominant language
TypeScript
Stars
853
Forks
662
Avg merge
2d 8h
Merged PRs (30d)
8

Description

This mostly involves work around deeply nested struct definitions i.e. unions of unions. We need a way to reliably throw the correct error and perhaps give a diff of thrown errors all at once.

Contributor guide

Open the contributing guide

Research direction

Start in the snaps-rpc-methods code handling deeply nested struct definitions, especially unions of unions, and trace how validation errors are currently thrown. Define the expected behavior for reliably selecting the correct error and reporting a diff of all thrown errors; the work is done when those cases produce consistent, comprehensive messaging.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.