MetaMask / MetaMask/snaps

Refactor approvals to use new ApprovalController patterns

Open
#1,890 0 comments 0 reactions 0 assignees View on GitHub
snaps-unrefined-backlog
Dominant language
TypeScript
Stars
853
Forks
662
Avg merge
2d 8h
Merged PRs (30d)
8

Description

Refactor our use of approvals to use new ApprovalController patterns such as approval flows.

This will require close collaboration with the confirmation systems team to flesh out their API to support our custom loaders etc.

Contributor guide

Open the contributing guide

Research direction

Start by locating the existing approvals implementation and the new ApprovalController patterns, including approval flows. The confirmation systems team must first define an API that supports custom loaders; done means approvals use the agreed patterns and the API collaboration is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.