MetaMask / MetaMask/providers

Protect internals of the provider classes using hash names

Open
#243 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
268
Forks
130
PR merge metrics
No merged PRs in 30d

Description

Currently in `snaps-monorepo` we wrap the Ethereum provider in a `Proxy`, to prevent access to internal fields. A better alternative would be to protect these fields in the first place using hash names, which are not accessible in any way.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the provider classes in the TypeScript repository and reading how snaps-monorepo currently wraps the Ethereum provider in a Proxy. Identify the internal fields that require protection and review the provider tests, if present. Done means those internals are protected directly and the Proxy workaround is no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.