MetaMask / MetaMask/phishing-warning
`safelistPhishingDomain` message can be too slow. We need to wait until the backend receives the message before navigating.
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 20
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Improvements to the extension's phishing detection make it so much faster that we still end up blocking the request, as the message is received after our detection kicks in.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/index.ts at lines 242-249 and trace the safelistPhishingDomain message flow. Reproduce the timing where phishing detection blocks navigation before the backend receives the message; done means navigation waits for that receipt before proceeding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100