MetaMask / MetaMask/mpc-core-kit-swift

Share Descriptions seems incorrect

Open
#44 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
0
Forks
2
PR merge metrics
No merged PRs in 30d

Description

## Description
After testing #43 PR it looks like the share descriptions are incorrect. It considers every share as a hashed share.

```
"{\"0370d5cb4bf05041da97ce846e990d93c9897292d30f0593ee2f908b7627b07982\":[\"{\\\"tssIndex\\\":3,\\\"module\\\":\\\"hashedShare\\\",\\\"dateAdded\\\":1738821836}\"],\"0396a0d61f447bb0b8430a69a9248384825d32fc02945d17532228677f6db6caf6\":[\"{\\\"module\\\":\\\"hashedShare\\\",\\\"tssIndex\\\":2,\\\"dateAdded\\\":1738821830}\"],\"04b168b23024b615c91719942b0b6ba6b26c23b1f5ec5c0726ecc8e03472ed9695f0818d622188d6f7ec0b280deeb7e1929a03318ecace8d57b4208a72865ebfef\":[\"{\\\"module\\\":\\\"hashedShare\\\",\\\"tssIndex\\\":2,\\\"dateAdded\\\":1738821814}\"]}"
```

My MFA is enabled, so hashedShare details shouldn't be there, and since I have enabled the MFA there should be device share and recovery share instead of a hashedShare module.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the share-description output with MFA enabled, then trace where the share module descriptions are generated. Confirm how the current output is classified and identify the expected device-share and recovery-share values. Done means MFA-enabled accounts no longer report every share as hashedShare.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.