MetaMask / MetaMask/mpc-core-kit-swift
Naming Convention
- Dominant language
- Swift
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
## Description
- [x] In SDK we have used different language styles for enums. While some enum have UPPERCASE, some have lowercase. By default, Swift has no strict rules for enums, but lowerCamel is recommended. We should keep all enum values in Uppercase or all values in lowerCamelCase.
- [ ] We have used two different names for the same value. `factorTypeDescription` in `MFARecoveryFactor`, `factorDescription` in `createFactor` method. We should align it with the Web and keep it `shareDescription`?
- [ ] Rename `CoreKitWeb3AuthOptions` CoreKit to `Web3AuthOptions`. It makes it align with other SDKs.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the enum declarations, MFARecoveryFactor, createFactor, and CoreKitWeb3AuthOptions references in the Swift SDK. Review the corresponding Web naming and update the affected names consistently; done means enum values and option names follow the chosen convention and all references compile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100