MetaMask / MetaMask/metamask-onboarding

MetaMaskOnboarding._detectBrowser() detects Chrome as Firefox

Open
#93 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
150
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Hey,

The onboarding library is detecting the Chrome browser as Firefox.
This is causing the user to get redirected to Firefox AddOns URL: https://addons.mozilla.org/en-GB/firefox/addon/ether-metamask/

If the browser detection worked fine, it should ideally redirect the user to Chrome Web Store for the MetaMask Chrome Extension.

I'm using Chrome Version 101.0.4951.54 (Official Build) (arm64)
I'm using @metamask/onboarding package version 1.0.1
I'm using MacOS Monterey 12.3 (21E230)

PS: This issue appears to be on MacOS only. It works as expected on Windows 10 platform.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating MetaMaskOnboarding._detectBrowser() and reproduce the browser detection on Chrome 101 running on macOS Monterey. Verify that the fix identifies Chrome correctly and directs users to the Chrome Web Store instead of the Firefox Add-ons URL.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.