MetaMask / MetaMask/metamask-mobile

Increase test coverage for Vault.js

Open
#9,836 0 comments 0 reactions 1 assignee Claimed by @Gudahtt View on GitHub
team-mobile-platform tests
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

The file `app/core/Vault.js` has poor test coverage. The KeyringController v16 update required changes that further decreased coverage. However, adding more tests was blocked by challenges encountered using KeyringController in a test file.

As of https://github.com/MetaMask/core/pull/4362, we should have an easier time using the KeyringController in unit tests. Once that PR has been merged and released, we should update the KeyringController again in mobile, then follow up with additional unit tests for `app/core/Vault.js` that increase coverage to 100% for that file.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [x] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

Relates to https://github.com/MetaMask/metamask-mobile/pull/9570

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.