MetaMask / MetaMask/metamask-mobile
(mob) Ledger - Long term solution to improve on ERC20 swap approval to transaction flow
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
**What is this about?**
In related to [issue](https://github.com/MetaMask/metamask-mobile/issues/8667), only a quick temp fix was put in place.
In the long term, we shall evaluate a way to either use the latest component and regression test all the impact areas or have just 1 modal that can sit on the screen until both transactions are confirmed.
**Scenario**
Given a user is doing a ERC20 swap
When a user clicks confirm for the Ledger Approval flow
Then the user shall be able to see the second Approval for the Swap flow
**Stakeholder review needed before the work gets merged**
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing related issue 8667 and the existing Ledger approval flow in the mobile app. Evaluate the latest component versus a single modal, regression-test the affected areas, and verify that after confirming the Ledger approval the second swap approval remains visible until both transactions are confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- blockchain, mobile-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100