MetaMask / MetaMask/metamask-mobile

Password suggestions and autofill not working properly on password fields

Open
#9,195 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-mobile-platform
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### What is this about?

On android and iOS, the password management system that provides strong password suggestion and allows autofill is not properly handled by the multiple password fields we have in the app.

Some don't allow autofill and force copy-pasting, some fill in the wring field, some don't allow suggestion of a strong password at all.

Overall it's not consistant and adds friction for users who try to use strong passwords and handle them in their password manager.

- Allow suggestion of strong password when creating the wallet
- Allow use of saved password when unlocking the wallet
- Allow use of saved password when confirming the password before changing it
- Allow suggestion of strong password when changing the password and put the value in both password and confirmation fields

Screen recording of a few of the password behaviour:

https://github.com/MetaMask/metamask-mobile/assets/4677568/0782a5b4-e431-48f9-b6f9-582ebf32be8e

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

https://reactnative.dev/docs/0.70/textinput#autocomplete-android
https://reactnative.dev/docs/0.70/textinput#textcontenttype-ios

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the React Native TextInput autocomplete and iOS textContentType references, then locate the password fields used for wallet creation, unlocking, confirmation, and password changes. Compare their Android and iOS behavior with the supplied recording. Done means strong-password suggestions and saved-password autofill work consistently, including populating both change-password fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, ios, react-native, typescript
Domain
authentication, mobile, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.