MetaMask / MetaMask/metamask-mobile
Replace deprecated FA5Icon component with Icon from the component-library
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### **Description**
There are many instances in the mobile codebase where the outdated `FA5Icon` component (FontAwesome5) is still in use. These should be replaced with the new `Icon` component (`app/component-library/components/Icons/Icon/Icon.tsx`).
To support a smooth migration process across multiple contributors and maintain manageable PR sizes, **each pull request (PR) should focus on replacing a single instance** of the `FA5Icon` component. This makes it easier to review, test, and prevent regressions.
### **Technical Details**
- Replace one instance of `FA5Icon` with the new `Icon` component.
- Ensure all relevant props are updated to match the new API.
- Component APIs differ slightly—carefully review each usage to preserve behavior and appearance.
- Verify the replacement introduces no functional or visual regressions.
### **Acceptance Criteria**
- Only a single instance of `FA5Icon` is replaced in each PR.
- New `Icon` component is correctly integrated with proper props and logic.
- No visual or functional regressions are introduced.
- All Jest tests, e2e tests, linting, and Storybook must pass.
- PR descriptions must follow the provided template and include before/after UI screenshots.
PRs that do not meet these criteria may be closed or requested for revision.
### **Difficulty**: Intermediate
**Good first issue for:** External contributors who can run the mobile app locally and have experience with React Native, component APIs, and maintaining consistent UI and test coverage.
Contributor guide
Research direction
Search the mobile codebase for one FA5Icon instance, then read app/component-library/components/Icons/Icon/Icon.tsx to compare the component APIs. Replace only that occurrence while preserving its behavior and appearance. Verify the change with the relevant Jest tests, e2e tests, linting, and Storybook, and include before/after UI screenshots in the PR.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- frontend, mobile
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100