MetaMask / MetaMask/metamask-mobile

How to return Dapp when using WalletConnect to multiple times signatures?

Open
#7,255 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

#Description
When I connect to Metamask using wallet connect v2 I have an issue with redirection to dapp, redirect only work once. so i read the source code, I found that if your url params contains a session topic and it has been created and matched with this session, it will set the deep link of the corresponding session to true.

#Situation
so we wallet connect uri like this:

> `metamask://wc?uri=encodeUrl('wc:xxxx?sesstionTopic=session.topic')`, `xxxx` is any string

example:
```
metamask://wc?uri=wc%3A00e46b69-d0cc-4b3e-b6a2-cee442f97188%402%3FsessionTopic%3D644d376a045551072894aebd64c79ac1ec266385b15c95a72c999d3a20687cd0
```

![image](https://github.com/MetaMask/metamask-mobile/assets/20208598/19ea9b6b-aeed-43f1-9675-4892847331bd)

**Acceptance Criteria**
_What is a technical must-have for launch and in-scope._

*
![sign](https://github.com/MetaMask/metamask-mobile/assets/20208598/5bb1af7c-277d-4dd7-a694-135f9a5c5047)

*

**Process** (adapt per story)
- [ ] User research / data
- [ ] Ideation / Kickoff in cross-functional team
- [ ] Pattern research in mobile (crypto / non-crypto space)
- [ ] Proof of concept to check technical feasibility (if applicable)
- [ ] Design reviews with PM, Engineer(s)
- [ ] User testing
- [ ] Design - Dev handoff
- [ ] Implementation
- [ ] Code review
- [ ] Stakeholder review on latest build on iOS and Android
- [ ] QA - unit test, e2e tests, regression testing

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in MetaMask Mobile with the provided WalletConnect deep-link URI and repeated signature requests. Trace the WalletConnect session-topic handling and deep-link state on iOS and Android. Done means returning to the dapp works for multiple signature requests in the same session, with regression coverage for the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.