MetaMask / MetaMask/metamask-mobile
[BUG] - Loading failed favicon ico when website change
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### **Description**
example, in domain twitter, when twitter changed favicon, in metamask do not get right favicon.
please fix favicon with size 50, https://github.com/MetaMask/metamask-mobile/blob/a4b8ba99fd2ef0ebe0d43a02e21e5d8818ed1a5a/app/components/Views/BrowserTab/index.js#L859
### **To Reproduce**
https://api.faviconkit.com/twitter.com/50
https://api.faviconkit.com/twitter.com/1024
### **Smartphone (please complete the following information):**
all platform IOS and android.
Contributor guide
Research direction
Start at app/components/Views/BrowserTab/index.js around line 859 and compare the favicon responses from the linked faviconkit URLs for sizes 50 and 1024. The issue is done when the browser tab loads the correct favicon after a website changes it on both iOS and Android.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100