MetaMask / MetaMask/metamask-mobile
[Bug] Performing a Send from a Dapp displays Hex Data even if the option is disabled from Advanced Settings
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
**Describe the bug**
Whenever I disable displaying Hex Data from Advanced Settings, I can see how the `View Data` option is still there if I perform a Send (Send Legacy / Send EIP1559) from a Dapp.
**Screenshots**
https://github.com/MetaMask/metamask-mobile/assets/54408225/17be1110-ea53-4c6a-86bd-903d63f7b77d
**To Reproduce**
_Steps to reproduce the behavior_
1. Go to Advanced Settings
2. Disable Hex Data
3. Go to the test dapp https://metamask.github.io/test-dapp/
4. Connect MetaMask
5. Click Send EIP1559 or Send Legacy
6. See `View Data` is displayed
7. Click `View Data` see hex data
**Expected behavior**
If Hex Data is disabled from Settings, we should not see it on a Send from a test dapp.
**Smartphone (please complete the following information):**
- Device: Pixel 6
- OS: android
- App Version: `v6.6.0`
-------------------------------------------------------------
_to be added after bug submission by internal support / PM_
**Severity**
- How critical is the impact of this bug on a user?
- Add stats if available on % of customers impacted
- Is this visible to all users?
- Is this tech debt?
Contributor guide
Research direction
Reproduce the issue in the MetaMask mobile app using Advanced Settings and the linked test dapp, then trace the send flow for Send Legacy and Send EIP1559. Done means disabling Hex Data also removes the View Data option and prevents the hex data from being shown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- frontend, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100