MetaMask / MetaMask/metamask-mobile

[Bug]: `primaryType` is not displayed on any of the `signTyped` signature screens

Open
#5,590 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-signatures Sev3-low team-confirmations-planning type-bug type-pinned
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

**Describe the bug**
`primaryType` is not displayed on any of the `signTyped` signature screens. Instead, we see `Message` title on the signature header.
this issue is the same we had on Extension, see[ here](https://github.com/MetaMask/metamask-extension/issues/17076) for more context.

**Screenshots**

![image](https://user-images.githubusercontent.com/54408225/214277292-9595de6a-7250-4b50-8dfb-07ed7b99f91f.png)

**To Reproduce**
_Steps to reproduce the behavior_
1. Go to `https://metamask.github.io/test-dapp/`
2. Click on Connect
3. Click on any of the Sign type data -- see no primaryType is displayed, and instead the header shows `Message`

**Expected behavior**
We should display the `primaryType` of the signature as the header, instead of `Message` text.
See how this was resolved on Extension [here](https://github.com/MetaMask/metamask-extension/pull/17077).

**Smartphone (please complete the following information):**

- Device: Samsung SM-A217F
- OS: Android 11.0
- App Version: v5.12.3 (1033)

-------------------------------------------------------------
_to be added after bug submission by internal support / PM_
**Severity**

- How critical is the impact of this bug on a user?
- Add stats if available on % of customers impacted
- Is this visible to all users?
- Is this tech debt?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue at the MetaMask test dapp with a sign-typed request, then trace the mobile signTyped signature screens that currently show `Message`. Done means the signature header displays the request's `primaryType` instead of `Message` on every signTyped screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.