MetaMask / MetaMask/metamask-mobile

Convert ApproveView/Approve to functional component

Open
#5,574 1 comment 0 reactions 0 assignees View on GitHub
area-transactions team-confirmations-planning type-pinned type-tech-debt
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### **Description**

Convert [ApproveView/Approve](https://github.com/MetaMask/metamask-mobile/blob/main/app/components/Views/ApproveView/Approve/index.js) to functional component.

### **Acceptance Criteria**
- Approve page continue to work as before
- Use of legacy react api is removed

### **References**
https://docs.google.com/document/d/19xKY4e07UThOa1jsDQA8pjsNLUBRn39EdUbaFpz3OR0/edit?usp=sharing

Contributor guide

Open the contributing guide

Research direction

Start with app/components/Views/ApproveView/Approve/index.js and inspect how ApproveView/Approve is rendered and how its current behavior is covered. Convert the component while preserving the existing Approve page behavior, then verify that the legacy React API is no longer used.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
frontend, mobile
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.