MetaMask / MetaMask/metamask-mobile

[Bug]: Ledger: if swap is cancelled on the Ledger device, clicking Try again in swaps flow does nothing

Open
#33,966 4 comments 0 reactions 0 assignees View on GitHub
regression-RC-8.5.0 Sev2-normal ta-needs-engineer-escalation ta-triaged team-accounts-framework type-bug
Dominant language
TypeScript
Stars
3k
Forks
1.7k
Avg merge
1d 14h
Merged PRs (30d)
669

Description

### Describe the bug

Using Ledger device and performing a swap: if the swap transaction is rejected by the user on the Ledger device, then clicking Try again in the swaps flow does nothing and no transaction confirmation is received on the Ledger.

### Expected behavior

Clicking try again to resend confirmation on the Ledger device

### Screenshots/Recordings

https://github.com/user-attachments/assets/7398c040-1c3e-49a4-ba68-bb2878009b41

### Steps to reproduce

1. Connect Ledger
2. Click Swap
3. Reject transaction on Ledger
4. Notice Action cancelled modal
5. Click Continue
6. Click Try again
7. Notice nothing happen and no transaction request is received on the Ledger device

### Error messages or log output

```shell

```

### Where was this bug found?

Internal release testing

### Version

8.5.0

### Build number

6257

### Build type

_No response_

### Device

iPhone 15

### Operating system

iOS

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the swaps flow on an iPhone with a Ledger: reject the transaction, continue past the Action cancelled modal, and select Try again. Trace the entry point handling that retry and confirm the fix by verifying that a new transaction confirmation request reaches the Ledger device.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, react-native, typescript
Domain
blockchain, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.