MetaMask / MetaMask/metamask-mobile
[Rive][8.3.0] Verify Money onboarding animation (onboarding_flow_v23.riv) bindings
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
Part of #33825. Sentry: [METAMASK-MOBILE-5TM4](https://metamask.sentry.io/issues/METAMASK-MOBILE-5TM4).
## Context
In 8.3.0, #33052 swapped Money onboarding from the legacy `..._configurable_v2.riv` asset to **`onboarding_flow_v23.riv`**, again with the unverified claim that bindings match. Data-binding + a large asset make a name mismatch or teardown crash on the Rive worker thread plausible.
(Note: the asset was rolled again to v24 in 8.4.0 via #33260 — out of scope for this 8.3.0 regression issue, but worth verifying the same checks there.)
## What to check
- Artboard `Money_Account` + state machine `State Machine 1` exist in `v23`.
- Data-binding names match `AutoBind`: `button` (`useRiveString`), `transitionSpeed` (`useRiveNumber`), `close` (`useRiveTrigger`).
- `onError` handler present and correct (`MoneyOnboardingView.tsx`).
- `stop()` / clean teardown before navigating away (see #31076).
## Prior fix reference
- #31007 — gate onboarding stepper animation behind feature flag
- #31076 — stop rive before navigate
## PRs / people (no-ping)
- v23 swap (#33052): author `wachunei`; reviewers `AndyMBridges`, `Matt561`
- API refactor (#31724): author `Matt561`; reviewer `shane-t`
Contributor guide
Assessment
This issue has not been assessed yet.