MetaMask / MetaMask/metamask-mobile
[NAVREDESIGN] Tab Bar Component
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### **Description**
Create `Tab Bar` component to use for navigation
### **Technical Details**
- There are 2 ways to build this:
- 1. Customize react-navigation's tab bar view to construct what is designed in Figma
- This really depends on if it's feasible. Most likely, we will not be able to "scroll underneath" the tab bar, which may result in the tab bar looking funny.
- 2. Position absolute the `Tab Bar` component on the root level so that it overlaps a portion of the app. This is almost guaranteed to allow "scroll underneath". However, it may seem weird to have a tab bar that is not tied to the navigation system. That is up for debate.
### **Acceptance Criteria**
- TBD
### **References**
- Figma - https://www.figma.com/file/qcwJHEEw5qyNru5mbFf6Oq/Nav-Redesign-Breakdown?node-id=101%3A647
- ETA - 4 Days
Contributor guide
Research direction
Start with the linked Figma Nav Redesign Breakdown and inspect the existing navigation setup to determine where the Tab Bar belongs. Compare the two implementation approaches described in the issue, clarify the missing acceptance criteria, and treat the work as done only once the chosen approach matches the design and supports the intended scrolling behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- frontend, mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100