MetaMask / MetaMask/metamask-mobile
[Bug]: Trader Trades page - missing Maskicon fallback for traders without profile image
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### Describe the bug
On the **Trader Trades page** (accessible from the Leaderboard), when a trader does not have a profile image, the avatar falls back to showing **"0"** in a grey circle instead of a **Maskicon** seeded by the trader's wallet address.
This was not covered by [TSA-636](https://consensyssoftware.atlassian.net/browse/TSA-636), which updated the Maskicon fallback for `TopTraderCard`, `TraderRow`, and `ProfileHeader` — but missed the Trades list component within the trader's profile view.
### Expected behavior
As aligned with [TSA-636](https://consensyssoftware.atlassian.net/browse/TSA-636), all trader avatar instances across the app should use **Maskicon** (seeded by `trader.address`) as the fallback when no profile image is available. The Trades page should be consistent with the rest of the app.
### Screenshots/Recordings
_Screenshot to be attached: shows TIBBIR trader trades page with "0" displayed in grey circles as avatar fallback for trade items (sold/bought), instead of Maskicon._
### Steps to reproduce
1. Open MetaMask Mobile
2. Navigate to the **Leaderboard**
3. Tap on a trader that **does not have a profile image**
4. Navigate to the **Trades** tab on their profile
5. Observe that the avatar next to each trade item shows **"0"** in a grey circle instead of a Maskicon
### Error messages or log output
_No error message displayed._
### Where was this bug found?
Internal release testing
### Version
8.0.0
### Build number
5533
### Build type
_No response_
### Device
iPhone
### Operating system
iOS
### Additional context
- Related Jira task: [TSA-636](https://consensyssoftware.atlassian.net/browse/TSA-636) — which defines the Maskicon fallback pattern and the components already updated
- The Trades list component in the trader profile view appears to be a **4th avatar instance** not covered by TSA-636
- Likely component to update: the trade item renderer in the Trader Profile Trades view — same fix pattern as TSA-636: replace the `AvatarBase` fallback with `AvatarAccount` using `AvatarAccountVariantTypes.Maskicon` seeded by `trader.address`
- Team: Social
### Severity
_To be filled by internal support / PM_
[TSA-636]: https://consensyssoftware.atlassian.net/browse/TSA-636?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[TSA-636]: https://consensyssoftware.atlassian.net/browse/TSA-636?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[TSA-636]: https://consensyssoftware.atlassian.net/browse/TSA-636?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Contributor guide
Research direction
Locate the trade item renderer in the Trader Profile Trades view and compare its avatar handling with the components updated for TSA-636. Verify the no-profile-image path on the Trader Trades page, using the trader address as the Maskicon seed, and confirm that trade items no longer show the grey “0” fallback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- frontend, mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100