MetaMask / MetaMask/metamask-mobile
Remove BIP-44 flag and/or selector from confirmations code and keep State 2 code path only
- Dominant language
- TypeScript
- Stars
- 3k
- Forks
- 1.7k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 669
Description
### What is this about?
Remove the usage of the BIP-44 flag and/or selector (`isMultichainAccountsState2Enabled` and `selectMultichainAccountsState2Enabled`) from the confirmations area and simplify the code by keeping only the behavior that runs when the selector returns true (multichain accounts state 2 / BIP-44 path). This is a follow-up cleanup once the feature is considered stable and the legacy path is no longer needed.
- File: [app/components/Views/confirmations/hooks/send/useSendScope.ts](https://github.com/MetaMask/metamask-mobile/app/components/Views/confirmations/hooks/send/useSendScope.ts)
- File: [app/components/Views/confirmations/components/modals/switch-account-type-modal/account-network-row/account-network-row.tsx](https://github.com/MetaMask/metamask-mobile/app/components/Views/confirmations/components/modals/switch-account-type-modal/account-network-row.tsx)
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Start by reading the two listed confirmation files: useSendScope.ts and account-network-row.tsx. Trace the isMultichainAccountsState2Enabled and selectMultichainAccountsState2Enabled usages, then verify that the confirmations area retains only the State 2 behavior and no longer depends on the legacy path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100